Adding a checksum value and commenting out windows build since it is … (

#114)

* Adding a checksum value and commenting out windows build since it is failing atm

* Adding windows commands back after PR 115

* Forgot to rename the windows archive for generating the md5

* Adding requires parameter for the test job with tagges builds

* Adding golangci install to the build for tagged builds

* install-golangci-lint command needs to be part of a step

* Change the steps for build to call lint job

* Adding presistence for the govet step

* Updating path for presistence of govet

* Adding govet install to the build job

* Need to attach to the workspace

* add working directory

* Adding checkout step back

* Remove attach statement

* Add call to install golangci-lint again

* Update GHR command options

* Update presistence to grab the entire build dir

* Debug circleci env

* Upload everything in the build dir and remove debug info

Co-authored-by: mattermod <mattermod@users.noreply.github.com>

.circleci/config.yml

@@ -165,12 +165,17 @@ jobs:
       name: default
     steps:
       - checkout
+      - run:
+          name: "Validate lint"
+          command: |
+            echo "Installing mattermost-govet"
+            GO111MODULE=off go get -u github.com/mattermost/mattermost-govet
+      - install-golangci-lint
       - run: make package
       - persist_to_workspace:
           root: .
           paths:
-            - ./build/*.tar.gz
-            - ./build/*.zip
+            - build
 
   publish-github-release:
     docker:
@@ -181,8 +186,7 @@ jobs:
       - run:
           name: "Publish Release on GitHub"
           command: |
-            ghr -t ${GITHUB_TOKEN} -u ${CIRCLE_PROJECT_USERNAME} -r ${CIRCLE_PROJECT_REPONAME} -c ${CIRCLE_SHA1} -delete ${CIRCLE_TAG} ./build/*.tar.gz
-            ghr -t ${GITHUB_TOKEN} -u ${CIRCLE_PROJECT_USERNAME} -r ${CIRCLE_PROJECT_REPONAME} -c ${CIRCLE_SHA1} -delete ${CIRCLE_TAG} ./build/*.zip
+            ghr -t ${GITHUB_TOKEN} -u ${CIRCLE_PROJECT_USERNAME} -r ${CIRCLE_PROJECT_REPONAME} -c ${CIRCLE_SHA1} -delete ${CIRCLE_TAG} build
 
 workflows:
   version: 2
@@ -215,6 +219,8 @@ workflows:
             branches:
               ignore: /.*/
       - test:
+          requires:
+              - setup
           filters:
             tags:
               only: /^v.*/

Makefile

@@ -2,7 +2,7 @@
 GO_PACKAGES=$(shell go list ./...)
 GO ?= $(shell command -v go 2> /dev/null)
 BUILD_HASH ?= $(shell git rev-parse HEAD)
-BUILD_VERSION ?= $(shell git ls-remote --tags --refs --sort="v:refname" git://github.com/mattermost/mmctl | tail -n1 | sed 's/.*\///')
+BUILD_VERSION ?= $(shell git ls-remote --tags --refs git://github.com/mattermost/mmctl | tail -n1 | sed 's/.*\///')
 # Needed to avoid install shadow in brew which is not permitted
 ADVANCED_VET ?= TRUE
 
@@ -13,6 +13,7 @@ all: build
 
 build: vendor check
 	go build -ldflags '$(LDFLAGS)' -mod=vendor
+	md5sum < mmctl | cut -d ' ' -f 1 > mmctl.md5.txt
 
 install: vendor check
 	go install -ldflags '$(LDFLAGS)' -mod=vendor
@@ -23,14 +24,17 @@ package: vendor check
 	@echo Build Linux amd64
 	env GOOS=linux GOARCH=amd64 go build -mod=vendor
 	tar cf build/linux_amd64.tar mmctl
+	md5sum < build/linux_amd64.tar | cut -d ' ' -f 1 > build/linux_amd64.tar.md5.txt
 
 	@echo Build OSX amd64
 	env GOOS=darwin GOARCH=amd64 go build -mod=vendor
 	tar cf build/darwin_amd64.tar mmctl
+	md5sum < build/darwin_amd64.tar | cut -d ' ' -f 1 > build/darwin_amd64.tar.md5.txt
 
 	@echo Build Windows amd64
 	env GOOS=windows GOARCH=amd64 go build -mod=vendor
 	zip build/windows_amd64.zip mmctl.exe
+	md5sum < build/windows_amd64.zip | cut -d ' ' -f 1 > build/windows_amd64.zip.md5.txt
 
 	rm mmctl mmctl.exe