Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme file #404

Merged
merged 2 commits into from
Nov 3, 2021
Merged

update readme file #404

merged 2 commits into from
Nov 3, 2021

Conversation

isacikgoz
Copy link
Member

Summary

We should not use -u flag when installing mmctl. From the documentation:

The -u flag instructs get to update modules providing dependencies
of packages named on the command line to use newer minor or patch
releases when available.

This can cause some pain when trying to install if there are new versions of the dependencies.

Example: https://community-daily.mattermost.com/core/pl/dcfrp6nzptyuz89q5uziwcu9ic

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #404 (bc7f696) into master (2097bbf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files          45       45           
  Lines        4619     4619           
=======================================
  Hits         3103     3103           
  Misses       1315     1315           
  Partials      201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2097bbf...bc7f696. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@isacikgoz isacikgoz merged commit d9ba920 into master Nov 3, 2021
@isacikgoz isacikgoz deleted the fix-go-get branch November 3, 2021 07:33
@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 3, 2021
@isacikgoz isacikgoz removed the request for review from mgdelacroix November 3, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants