Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare mmctl to next 6.2 release #419

Merged
merged 1 commit into from
Dec 17, 2021
Merged

prepare mmctl to next 6.2 release #419

merged 1 commit into from
Dec 17, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Dec 15, 2021

Summary

  • prepare mmctl to next 6.2 release

Ticket Link

@cpanato
prepare mmctl to next 6.2 release
fb1696c 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@amyblais amyblais added the 2: Dev Review Requires review by a core committer label Dec 15, 2021
@amyblais
Copy link
Member

Seems some tests are failing.

@cpanato
Copy link
Contributor Author

cpanato commented Dec 15, 2021

Seems some tests are failing.

i will check those, maybe something changed

@codecov-commenter
Copy link

Codecov Report

Merging #419 (fb1696c) into release-6.2 (8ab71ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-6.2     #419   +/-   ##
============================================
  Coverage        67.17%   67.17%           
============================================
  Files               45       45           
  Lines             4619     4619           
============================================
  Hits              3103     3103           
  Misses            1315     1315           
  Partials           201      201
Impacted Files Coverage Δ
commands/version.go 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab71ce...fb1696c. Read the comment docs.

@cpanato
Copy link
Contributor Author

cpanato commented Dec 17, 2021

Seems some tests are failing.

all good now

@amyblais
Copy link
Member

@cpanato Do I need to wait for this PR before I cut v6.2.1 Final?

@cpanato
Copy link
Contributor Author

cpanato commented Dec 17, 2021

@cpanato Do I need to wait for this PR before I cut v6.2.1 Final?

yes

@amyblais
Copy link
Member

@mgdelacroix @isacikgoz Would one of you be able to help review this as a priority?

@amyblais amyblais requested review from mgdelacroix and removed request for amyblais December 17, 2021 14:28
isacikgoz
isacikgoz approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have a flaky test, I just re-run the tests and everything is OK now. LGTM 👍

mgdelacroix
mgdelacroix approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 17, 2021
@cpanato cpanato merged commit 8cedc5f into release-6.2 Dec 17, 2021
@cpanato cpanato deleted the update-6.2.1 branch December 17, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@isacikgoz isacikgoz isacikgoz approved these changes

Assignees

@cpanato cpanato

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @amyblais @codecov-commenter @mgdelacroix @isacikgoz