Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Applied correction #431

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Applied correction #431

merged 3 commits into from
Aug 8, 2022

Conversation

cwarnermm
Copy link
Member

Documentation correction for: mattermost/docs#5380

@cwarnermm cwarnermm added the 2: Dev Review Requires review by a core committer label Jan 25, 2022
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mgdelacroix
Copy link
Member

@cwarnermm I've ported the change to the code files (and modified the other command accordingly) as those are used as the source of truth to generate the .rst files and that was causing the CI to fail.

Changes were done on a04fa66, please take a look and merge if you think they're good!! :)

@cwarnermm
Copy link
Member Author

Thanks, @mgdelacroix! The changes on a04fa66 look great. In fact, one of your code changes alerted me to the fact that the docs contain one more error that needs to be corrected (mmctl team users remove) due to users missing in the example. Addressed that issue via mattermost/docs#5383

@cwarnermm
Copy link
Member Author

Thank you, @mgdelacroix, for ported the change to the code files! Really appreciate the help on this one!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 18, 2022
@cwarnermm
Copy link
Member Author

/update-branch

@noxer
Copy link
Contributor

noxer commented Aug 4, 2022

What is missing for this PR to be merged or closed?

@cwarnermm
Copy link
Member Author

@noxer I noticed that the Files changed tab contains 0 entries. If I were to merge this PR, I'm not 100% clear on what would happen, if anything. Thoughts?

@noxer
Copy link
Contributor

noxer commented Aug 8, 2022

I think that means the changes are already in the codebase. I guess nothing would happen.

@cwarnermm
Copy link
Member Author

Thanks, @noxer. @mgdelacroix applied the changes via a specific commit, so I agree that we're likely okay to simply merge or close this PR. I'll merge it.

@cwarnermm cwarnermm merged commit eae1e37 into master Aug 8, 2022
@cwarnermm cwarnermm deleted the mmctl-correction branch August 8, 2022 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants