-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
Documentation for: mattermost/docs#5380
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@cwarnermm I've ported the change to the code files (and modified the other command accordingly) as those are used as the source of truth to generate the Changes were done on a04fa66, please take a look and merge if you think they're good!! :) |
Thanks, @mgdelacroix! The changes on a04fa66 look great. In fact, one of your code changes alerted me to the fact that the docs contain one more error that needs to be corrected ( |
Thank you, @mgdelacroix, for ported the change to the code files! Really appreciate the help on this one! |
/update-branch |
What is missing for this PR to be merged or closed? |
@noxer I noticed that the Files changed tab contains 0 entries. If I were to merge this PR, I'm not 100% clear on what would happen, if anything. Thoughts? |
I think that means the changes are already in the codebase. I guess nothing would happen. |
Thanks, @noxer. @mgdelacroix applied the changes via a specific commit, so I agree that we're likely okay to simply merge or close this PR. I'll merge it. |
Documentation correction for: mattermost/docs#5380