This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 155
[MM-41339] commands/webhook: add user id to the request payload #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
reviewed
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there's a way to write a stronger test for this? Maybe like an e2e test which makes an app layer call to get the webhook and verify the userid?
agnivade
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant!
I removed the QA review label. Did you want a QA review as well? |
Yeah, I think the automated test covers this. Thanks @agnivade! 🤗 |
stafot
added a commit
that referenced
this pull request
Mar 3, 2022
* replace circleci to use github actions (#430) * replace circleci to use github actions * add dependabot * update based on feedback * Pin golangci to a version (#445) Master is broken due to this. Pinning this keeps the code stable and we can make changes slowly. * update ci to run on release branches as well (#446) * MM-41184: Throw a warning if config migrate wasn't run in local mode (#435) Also added a note in the docs. Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * update enterprise hash (#437) Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * [MM-41339] commands/webhook: add user id to the request payload (#436) * commands/webhook: add user id to the request payload * add e2e test * [MM-41665] Set the AllowOpenInvite field to define public/invite only teams (#461) * update dependencies 6.4 (#463) * prepare release 6.4.1 (#464) * prepare release 6.4.2 (#466) Co-authored-by: Carlos Tadeu Panato Junior <carlos@mattermost.com> Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com> Co-authored-by: Angelos Kyratzakos <akyratzakos@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the forgotten user id to the webhook.
Ticket Link
https://mattermost.atlassian.net/browse/MM-41339