Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-41339] commands/webhook: add user id to the request payload #436

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

isacikgoz
Copy link
Member

Summary

Adds the forgotten user id to the webhook.

Ticket Link

https://mattermost.atlassian.net/browse/MM-41339

@isacikgoz isacikgoz added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 1, 2022
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if there's a way to write a stronger test for this? Maybe like an e2e test which makes an app layer call to get the webhook and verify the userid?

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@agnivade agnivade added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 3, 2022
@agnivade
Copy link
Member

agnivade commented Feb 3, 2022

I removed the QA review label. Did you want a QA review as well?

@isacikgoz
Copy link
Member Author

Yeah, I think the automated test covers this. Thanks @agnivade! 🤗

@isacikgoz isacikgoz merged commit cb6a7c9 into master Feb 3, 2022
@isacikgoz isacikgoz deleted the MM-41339 branch February 3, 2022 15:27
stafot added a commit that referenced this pull request Mar 3, 2022
* replace circleci to use github actions (#430)

* replace circleci to use github actions

* add dependabot

* update based on feedback

* Pin golangci to a version (#445)


Master is broken due to this. Pinning this keeps the code stable and we can make changes slowly.

* update ci to run on release branches as well (#446)

* MM-41184: Throw a warning if config migrate wasn't run in local mode (#435)

Also added a note in the docs.

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* update enterprise hash (#437)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* [MM-41339] commands/webhook: add user id to the request payload (#436)

* commands/webhook: add user id to the request payload

* add e2e test

* [MM-41665] Set the AllowOpenInvite field to define public/invite only teams (#461)

* update dependencies 6.4 (#463)

* prepare release 6.4.1 (#464)

* prepare release 6.4.2 (#466)

Co-authored-by: Carlos Tadeu Panato Junior <carlos@mattermost.com>
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com>
Co-authored-by: Angelos Kyratzakos <akyratzakos@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants