This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Makefile: get version from the git tags #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stafot
approved these changes
Mar 23, 2022
ghost
approved these changes
Mar 23, 2022
spirosoik
approved these changes
Mar 23, 2022
|
thanks @agnivade and @isacikgoz for the help here |
agnivade
added
4: Reviews Complete
|
@pfltdv / @spirosoik - So the changes from my previous comment is that the version info is taken from the git tag, not the branch name. Just for clarity. |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 30, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 30, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
* Makefile: get version from the git tags (#488) * Populate DIST_VER from tags related to v6.3.X Signed-off-by: Mustafa Kara <mkara@pinchflat.dev> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
* Makefile: get version from the git tags (#488) * Populate DIST_VER from tags related to v6.4.X Signed-off-by: Mustafa Kara <mkara@pinchflat.dev> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We get the version number from the recent git tags. So if we need to build this for release, we need to create the tag before releasing.
Ticket Link
https://mattermost.atlassian.net/browse/MM-42701