Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

commands/auth: fix 0-return on unsuccessful login attempts #499

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

isacikgoz
Copy link
Member

An unsuccessful command should always return a non zero return value, this PR aims to fix this issue.

Summary

Fixes #454

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Apr 4, 2022
@isacikgoz isacikgoz requested a review from agnivade April 4, 2022 20:07
commands/auth.go Outdated Show resolved Hide resolved
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 6, 2022
@isacikgoz isacikgoz merged commit 3abf3e8 into master Apr 6, 2022
@isacikgoz isacikgoz deleted the fix-auth-exit-status branch April 6, 2022 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth login exits with status 0 even for a non-working URL
2 participants