This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Upgrade golint version to v1.45.2 #504
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Kara <mkara@pinchflat.dev>
Signed-off-by: Mustafa Kara <mkara@pinchflat.dev>
ghost
assigned spirosoik, isacikgoz, phoinixgrr and ghost
and unassigned spirosoik, isacikgoz and phoinixgrr
ghost
requested review from
spirosoik
approved these changes
Apr 5, 2022
phoinixgrr
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
🎖️ Great work!
@pfltdv Could you provide some context on 62ef3a8 ?
@phoinixgrr, that line is not compatible with lintin rules. Somehow it was skipped on master. Rule: So removed dot at the end. |
ghost
added
4: Reviews Complete
Awesome, Thanks for this @pfltdv 👍 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.