This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
MM-38701: Automatically retry on a failed export download #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a resume functionality which would download the file again from a given offset. But clients would create wrapper scripts which would auto-retry. Therefore, we add that functionality in-built and deprecate the resume flag. The reasoning behind removing the flag is that if it doesn't succeed within 5 tries, then probably it's better to attempt to download the file from scratch again sometime later. https://mattermost.atlassian.net/browse/MM-38701
|
Wouldn't it make sense to make the number of retries configurable. I can imaging people with an unstable internet connection wanting to retry it more often. Maybe even interpret a negative number as infinite retries. |
|
That makes more sense. I'll make the changes. |
|
@noxer - PTAL |
|
Does the initial attempt count as a retry? It's a bit ambiguous but in this case |
|
Heh good point, will update. |
isacikgoz
reviewed
Jun 8, 2022
noxer
approved these changes
Jun 9, 2022
isacikgoz
added
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a resume functionality which would download the file
again from a given offset. But clients would create wrapper
scripts which would auto-retry.
Therefore, we add that functionality in-built and deprecate
the resume flag. The reasoning behind removing the flag is that
if it doesn't succeed within 5 tries, then probably it's better
to attempt to download the file from scratch again sometime later.
https://mattermost.atlassian.net/browse/MM-38701