Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

bump mm server dependency to v7.1 #540

Merged
merged 3 commits into from
Aug 4, 2022
Merged

bump mm server dependency to v7.1 #540

merged 3 commits into from
Aug 4, 2022

Conversation

isacikgoz
Copy link
Member

Summary

Bump server dependency to v7.1+

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Aug 1, 2022
@isacikgoz
Copy link
Member Author

Lint step is failing on gitlab due to an outdated build image I guess. @pfltdv I couldn't find a way to fix it, do you have any idea?

@ghost
Copy link

ghost commented Aug 4, 2022

Lint step is failing on gitlab due to an outdated build image I guess. @pfltdv I couldn't find a way to fix it, do you have any idea?

@isacikgoz it is failing with below error

vendor/github.com/mattermost/mattermost-server/v6/store/sqlstore/channel_store.go:4160:13: undefined: any
note: module requires Go 1.18
make: *** [Makefile:127: govet] Error 2

At pipeline docker.io/golangci/golangci-lint:v1.42.1 is used as runner for lint step. However go1.18 support is enabled at v1.45.0. We need to use newer container in lint job.

Is it possible to change docker image in .gitlab-ci.yml file in your PR?

image: docker.io/golangci/golangci-lint:v1.42.1

Recommended docker image:
docker.io/golangci/golangci-lint:v1.46.2@sha256:fe844e60e9bbf8d4df3305bcb8553e620b926ead4dc45d755b1cdc69d5949abf

@isacikgoz
Copy link
Member Author

Thanks for the heads up @pfltdv Updated the file and everything seems okay. I was looking into files under .gitlab-ci/ directory. Totally missed the .gitlab-ci.yml file under the project root. Funny stuff 🤦

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 4, 2022
@isacikgoz isacikgoz merged commit 601ec7d into master Aug 4, 2022
@isacikgoz isacikgoz deleted the bump-dependency branch August 4, 2022 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants