-
Notifications
You must be signed in to change notification settings - Fork 155
Add subcommand for canceling export jobs #557
Add subcommand for canceling export jobs #557
Conversation
Hello @gabor-boros, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM @gabor-boros
- I read through the code
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @gabor-boros 🎉 Just a small change request, otherwise looks good.
@isacikgoz Thank you for your review! Your observations are addressed as part of 65daf40. Could you please do another round of review? Also, could you please guide me on how I could help out at mattermost/mattermost#21049 to get it merged? 😇 |
/update-branch |
@gabor-boros can you update the docs with |
Ah, sure @isacikgoz. Give me a day or two. 😌 |
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
FYI: @isacikgoz updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for all the effort @gabor-boros 🚀
Summary
At the moment, the mattermost client already knows how to cancel a job, but
mmctl
has no subcommands to expose this functionality and cancel an export job.This PR adds a new subcommand
mmctl export job cancel [export job id]
to cancel an export job.Ticket Link
This PR is not resolving any open issues in Jira or GitHub. If necessary, I can create a GitHub issue to be able to link the PR to that.
Testing instructions
mmctl export job cancel <ID>
First, the export job's state should be
cancel_requested
, then it should switch tocanceled
after some time.Example
Documentation
Although it was not completely necessary to update the
mmctl export job show
subcommand's example usage, I did it to have a more consistent documentation.