Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

#21213 - Add error handling for archiveChannelsCmdF #568

Merged
merged 7 commits into from
Nov 25, 2022
Merged

#21213 - Add error handling for archiveChannelsCmdF #568

merged 7 commits into from
Nov 25, 2022

Conversation

seowglen
Copy link
Contributor

@seowglen seowglen commented Oct 7, 2022

WHAT'S NEW

  1. Add error handling for archiveChannelsCmdF
  2. Assert error returned for unit tests
  3. Add E2E tests for archiveChannelsCmdF

Fixes mattermost/mattermost#21213

@mattermod
Copy link
Contributor

Hello @seowglen,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@seowglen
Copy link
Contributor Author

seowglen commented Oct 7, 2022

/check-cla

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

isacikgoz
isacikgoz suggested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice extensive testing! Nice job @seowglen 💪 Can you address the linter issues and the comments I've added?

commands/channel_e2e_test.go Show resolved Hide resolved
commands/channel_e2e_test.go Outdated Show resolved Hide resolved
@seowglen
Copy link
Contributor Author

Have addressed comments and resolved merge conflicts, please have a look at it again 😊

noxer
noxer suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seowglen, thank you very much for your contribution. I'd like to request a couple of small changes. Please also address the complaint from the linter. Other than that it looks good to me.

commands/channel.go Outdated Show resolved Hide resolved
commands/channel.go Outdated Show resolved Hide resolved
commands/channel.go Outdated Show resolved Hide resolved
@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 24, 2022
@seowglen
Copy link
Contributor Author

@noxer resolved comments!

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

noxer
noxer approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much @seowglen.

@isacikgoz
Copy link
Member

/update-branch

@isacikgoz isacikgoz self-requested a review November 22, 2022 19:23
isacikgoz
isacikgoz approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seowglen 🚀

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 25, 2022
@isacikgoz isacikgoz merged commit bc27e27 into mattermost:master Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noxer noxer noxer approved these changes

@isacikgoz isacikgoz isacikgoz approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mmctl: Review archiveChannelsCmdF function to return an error in case of a failure
4 participants
@seowglen @mattermod @isacikgoz @noxer