ref: return multi-error from moveChannelCmdF #570

s4kh · 2022-10-09T00:57:47Z

Summary

Returns multi error instead of printing and returning nil

Ticket Link

mattermod · 2022-10-09T00:57:50Z

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

isacikgoz

Thanks for the contribution @s4kh I commented on things that needs to be addressed.

commands/channel.go

commands/channel_e2e_test.go

commands/channel_test.go

mattermod · 2022-10-31T01:04:10Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

noxer

Thank you very much for your contribution @s4kh and apologies for the delay. The code looks good. I've suggested a few minor changes in the tests.

commands/channel_e2e_test.go

commands/channel_test.go

mattermod · 2022-11-11T01:04:07Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

noxer

Looks good, thank you very much @s4kh 🎉

isacikgoz

LGTM, thanks @s4kh 🎉

mattermod added Hacktoberfest hacktoberfest-accepted labels Oct 9, 2022

s4kh force-pushed the GH-21214 branch from 1710790 to ff9311f Compare October 11, 2022 19:57

isacikgoz requested review from noxer and isacikgoz October 18, 2022 10:29

isacikgoz suggested changes Oct 19, 2022

View reviewed changes

commands/channel.go Outdated Show resolved Hide resolved

commands/channel_e2e_test.go Outdated Show resolved Hide resolved

commands/channel_test.go Outdated Show resolved Hide resolved

s4kh force-pushed the GH-21214 branch from ff9311f to 46ba92d Compare October 19, 2022 19:54

s4kh requested review from isacikgoz and removed request for noxer October 19, 2022 19:54

s4kh force-pushed the GH-21214 branch 2 times, most recently from bfd2c2c to 14164c4 Compare October 20, 2022 19:04

mattermod added the Lifecycle/1:stale label Oct 31, 2022

noxer suggested changes Oct 31, 2022

View reviewed changes

noxer added 2: Dev Review Requires review by a core committer and removed Lifecycle/1:stale labels Oct 31, 2022

ref: return multi-error from moveChannelCmdF

b4d2fae

s4kh force-pushed the GH-21214 branch from 14164c4 to b4d2fae Compare October 31, 2022 16:52

s4kh requested review from noxer and isacikgoz and removed request for isacikgoz and noxer October 31, 2022 16:52

mattermod added the Lifecycle/1:stale label Nov 11, 2022

noxer removed the Lifecycle/1:stale label Nov 11, 2022

noxer approved these changes Nov 11, 2022

View reviewed changes

s4kh requested a review from isacikgoz November 15, 2022 07:49

isacikgoz approved these changes Nov 15, 2022

View reviewed changes

isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 15, 2022

isacikgoz merged commit 676a440 into mattermost:master Nov 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: return multi-error from moveChannelCmdF #570

ref: return multi-error from moveChannelCmdF #570

s4kh commented Oct 9, 2022

mattermod commented Oct 9, 2022

isacikgoz left a comment

mattermod commented Oct 31, 2022

noxer left a comment

mattermod commented Nov 11, 2022

noxer left a comment

isacikgoz left a comment

ref: return multi-error from moveChannelCmdF #570

ref: return multi-error from moveChannelCmdF #570

Conversation

s4kh commented Oct 9, 2022

Summary

Ticket Link

mattermod commented Oct 9, 2022

isacikgoz left a comment

Choose a reason for hiding this comment

mattermod commented Oct 31, 2022

noxer left a comment

Choose a reason for hiding this comment

mattermod commented Nov 11, 2022

noxer left a comment

Choose a reason for hiding this comment

isacikgoz left a comment

Choose a reason for hiding this comment