Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

MM-47825 demoteUserToGuestCmdF function to return an error in case of… #587

Merged
merged 5 commits into from
Oct 28, 2022
Merged

MM-47825 demoteUserToGuestCmdF function to return an error in case of… #587

merged 5 commits into from
Oct 28, 2022

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 22, 2022 •
edited
Loading

… a failure

Summary

Added multi error handing in demoteUserToGuestCmdF function

Ticket Link

fixes mattermost/mattermost#21461
JIRA: https://mattermost.atlassian.net/browse/MM-47825

@mattermod
Copy link
Contributor

Hello @joremysh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

noxer
noxer suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @joremysh, thank you for your contribution. I'd like to request a few changes. Besides those the PR looks good.

commands/user.go Outdated Show resolved Hide resolved
commands/user.go Outdated Show resolved Hide resolved
commands/user.go Outdated Show resolved Hide resolved
commands/user.go Outdated Show resolved Hide resolved
commands/user_test.go Outdated Show resolved Hide resolved
noxer
noxer approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much @joremysh. I've added Ibrahim to take another look.

@noxer noxer requested a review from isacikgoz October 25, 2022 13:41
@joremysh
Copy link
Contributor Author

@isacikgoz could you help check with it?

noxer
noxer suggested changes Oct 27, 2022
View reviewed changes
commands/user.go Outdated Show resolved Hide resolved
@joremysh joremysh requested review from noxer and removed request for isacikgoz October 28, 2022 04:19
@isacikgoz
Copy link
Member

/update-branch

noxer
noxer approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thank you @joremysh

@noxer noxer requested a review from isacikgoz October 28, 2022 08:23
isacikgoz
isacikgoz approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@isacikgoz isacikgoz added the 4: Reviews Complete All reviewers have approved the pull request label Oct 28, 2022
@noxer noxer merged commit 409e32d into mattermost:master Oct 28, 2022
@amyblais amyblais mentioned this pull request Mar 27, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noxer noxer noxer approved these changes

@isacikgoz isacikgoz isacikgoz approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mmctl: Review demoteUserToGuestCmdF function to return an error in case of a failure
4 participants
@joremysh @mattermod @isacikgoz @noxer