[MM-47814] - Refactor deleteTeamsCmdF function error handling #589
Conversation
|
Hello @enderahmetyurt, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
/check-cla |
There was a problem hiding this comment.
Thank you very much for your contribution @enderahmetyurt. I'd like to request a few changes. Also don't forget to sign the CLA, otherwise we'll be unable to merge.
There was a problem hiding this comment.
This looks good overall, thanks for the contribution @enderahmetyurt 🚀 You'll need to do a small change to make tests pass :) Suggested below 👇
enderahmetyurt
force-pushed
the
delete_teams_command_error_handle
branch
from
c896405
to
03fe56b
Compare
enderahmetyurt
requested review from
isacikgoz and
noxer
and removed request for
isacikgoz
There was a problem hiding this comment.
Thank you very much for your contribution @enderahmetyurt. I'd like to request a small change. Otherwise this looks good.
|
Apart from @noxer's comment, you'll need to update the |
enderahmetyurt
force-pushed
the
delete_teams_command_error_handle
branch
from
368f1fc
to
37a5c61
Compare
isacikgoz
added
the
4: Reviews Complete
Summary
This PR makes necessary changes for deleteTeamsCmdF function to return an error in case of a failure
Ticket Link
Fixes mattermost/mattermost#21472
JIRA: https://mattermost.atlassian.net/browse/MM-47814