Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Refactored verifyUserEmailWithoutTokenCmdF function to return an erro… #593

Conversation

amogh2019
Copy link
Contributor

Summary

Returns multi error instead of printing and returning nil

Ticket Link

Fixes mattermost/mattermost#21464

@mattermod
Copy link
Contributor

Hello @amogh2019,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@amogh2019
Copy link
Contributor Author

/check-cla

@noxer noxer requested review from isacikgoz and noxer October 24, 2022 16:30
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amogh2019, thank you very much for your contribution. I've got a few requests. Most of them are very minor, don't worry.
Also the linter wants the imports reordered in one of the files.

commands/user.go Outdated Show resolved Hide resolved
commands/user_e2e_test.go Outdated Show resolved Hide resolved
commands/user_e2e_test.go Outdated Show resolved Hide resolved
commands/user_test.go Outdated Show resolved Hide resolved
commands/user_test.go Outdated Show resolved Hide resolved
commands/user_e2e_test.go Show resolved Hide resolved
commands/user_e2e_test.go Outdated Show resolved Hide resolved
@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 24, 2022
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small change and we should be done.

commands/user.go Outdated Show resolved Hide resolved
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @amogh2019

@amogh2019
Copy link
Contributor Author

@isacikgoz Can we merge?

Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @amogh2019 🚀

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 26, 2022
@isacikgoz isacikgoz merged commit 6506140 into mattermost:master Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmctl: Review verifyUserEmailWithoutTokenCmdF function to return an error in case of a failure
4 participants