-
Notifications
You must be signed in to change notification settings - Fork 155
Refactored verifyUserEmailWithoutTokenCmdF function to return an erro… #593
Refactored verifyUserEmailWithoutTokenCmdF function to return an erro… #593
Conversation
…r in case of a failure
Hello @amogh2019, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amogh2019, thank you very much for your contribution. I've got a few requests. Most of them are very minor, don't worry.
Also the linter wants the imports reordered in one of the files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small change and we should be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @amogh2019
@isacikgoz Can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @amogh2019 🚀
Summary
Returns multi error instead of printing and returning nil
Ticket Link
Fixes mattermost/mattermost#21464