Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-47818] userInviteCmdF function to return an error in case of a failure #595

Merged
merged 4 commits into from
Nov 1, 2022
Merged

[MM-47818] userInviteCmdF function to return an error in case of a failure #595

merged 4 commits into from
Nov 1, 2022

Conversation

ellisonleao
Copy link
Contributor

Summary

Added multi error handing in userInviteCmdF function

Ticket Link

Fixes: mattermost/mattermost#21468
Jira: https://mattermost.atlassian.net/browse/MM-47818

@mattermod
Copy link
Contributor

Hello @ellisonleao,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ellisonleao, thank you very much for your contribution. I'd like to suggest a few improvements and the linter complains about the order of the imports.

commands/user_test.go Outdated Show resolved Hide resolved
commands/user_test.go Outdated Show resolved Hide resolved
commands/user_test.go Outdated Show resolved Hide resolved
commands/user.go Outdated Show resolved Hide resolved
@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 28, 2022
@noxer noxer requested a review from isacikgoz October 28, 2022 09:54
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ellisonleao, this looks good to me.

Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ellisonleao LGTM!

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 1, 2022
@isacikgoz isacikgoz merged commit fb336d3 into mattermost:master Nov 1, 2022
@ellisonleao ellisonleao deleted the issue-21468 branch November 1, 2022 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmctl: Review userInviteCmdF function to return an error in case of a failure
4 participants