Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-47810] Return error from rolesMemberCmdF #596

Merged
merged 2 commits into from
Oct 27, 2022
Merged

[MM-47810] Return error from rolesMemberCmdF #596

merged 2 commits into from
Oct 27, 2022

Conversation

ermanimer
Copy link
Contributor

@ermanimer ermanimer commented Oct 25, 2022

Return error from rolesMemberCmdF

I applied the same approach with rolesSystemAdminCmd function.

Ticket: mattermost/mattermost#21476

JIRA Issue: https://mattermost.atlassian.net/browse/MM-47810

@mattermod
Copy link
Contributor

Hello @ermanimer,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@ermanimer ermanimer changed the title Return error from rolesMemberCmdF [MM-21476] Return error from rolesMemberCmdF Oct 25, 2022
@ermanimer
Copy link
Contributor Author

/check-cla

@ermanimer ermanimer changed the title [MM-21476] Return error from rolesMemberCmdF [MM-47810] Return error from rolesMemberCmdF Oct 25, 2022
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ermanimer 🎉

@ermanimer
Copy link
Contributor Author

Thank you @isacikgoz 😄

Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @ermanimer. Looks good to me.

@noxer noxer merged commit da4a8d3 into mattermost:master Oct 27, 2022
@ermanimer
Copy link
Contributor Author

Thank you @noxer 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants