-
Notifications
You must be signed in to change notification settings - Fork 155
refact: removeAllUsersFromChannel to return an error #599
Conversation
Hello @moogacs, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution, @moogacs. I'd like to request a few changes and there seem to be linter errors to fix (a simple go fmt
should take care of those).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution @moogacs.
The PR looks good. I've added a nit but feel free to ignore it, it's not that important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
refactor removeAllUsersFromChannel to feedback the error on return instead of just printing
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-47341
Issue: mattermost/mattermost#21218