Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

refact: removeAllUsersFromChannel to return an error #599

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Oct 27, 2022

Summary

refactor removeAllUsersFromChannel to feedback the error on return instead of just printing

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-47341
Issue: mattermost/mattermost#21218

@mattermod
Copy link
Contributor

Hello @moogacs,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@moogacs
Copy link
Contributor Author

moogacs commented Oct 27, 2022

/check-cla

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution, @moogacs. I'd like to request a few changes and there seem to be linter errors to fix (a simple go fmt should take care of those).

commands/channel_users.go Outdated Show resolved Hide resolved
commands/channel_users.go Outdated Show resolved Hide resolved
@noxer noxer added 2: Dev Review Requires review by a core committer and removed Lifecycle/1:stale labels Nov 17, 2022
@moogacs moogacs requested a review from noxer November 17, 2022 21:20
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @moogacs.
The PR looks good. I've added a nit but feel free to ignore it, it's not that important.

commands/channel_users_test.go Outdated Show resolved Hide resolved
@noxer noxer requested a review from isacikgoz November 18, 2022 10:38
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @moogacs 🎉 good to merge after what @noxer pointed out.

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 18, 2022
@isacikgoz isacikgoz merged commit ef217d5 into mattermost:master Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants