Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-47351] | Add error handling for integrityCmdF function #600

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

ShajithaMohammed
Copy link
Contributor

Summary

Returns multi error instead of printing and returning nil

Ticket Link

Fixes mattermost/mattermost#21209

@mattermod
Copy link
Contributor

Hello @ShajithaMohammed,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 28, 2022
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is complaining about the order of the imports. Besides that it looks good to me. Thank you for your contribution @ShajithaMohammed.

@noxer noxer requested a review from isacikgoz October 28, 2022 09:58
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort @ShajithaMohammed LGTM!

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 1, 2022
@isacikgoz isacikgoz merged commit 6d2d535 into mattermost:master Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmctl: Review integrityCmdF function to return an error in case of a failure
4 participants