Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

MM-47811: improve error handling for removeUserFromTeam function #616

Conversation

hionay
Copy link
Contributor

@hionay hionay commented Nov 23, 2022

Summary

Error handling for the removeUserFromTeam function updated to return an error in case of failure.
Update includes the use of multierror.Error for appending all errors and returning error if one occurs for the function teamUsersRemoveCmdF.

Ticket Link

Fixes mattermost/mattermost#21475

@mattermod
Copy link
Contributor

Hello @hionay,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hionay hionay changed the title [MM-47811]: improve error handling for removeUserFromTeam function MM-47811: improve error handling for removeUserFromTeam function Nov 28, 2022
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hionay, thank you very much for your contribution. I'd like to request a few changes. Otherwise this looks good.

commands/team_users.go Outdated Show resolved Hide resolved
commands/team_users_test.go Outdated Show resolved Hide resolved
commands/team_users_test.go Outdated Show resolved Hide resolved
@noxer noxer requested a review from isacikgoz December 2, 2022 15:39
@noxer noxer added the 2: Dev Review Requires review by a core committer label Dec 2, 2022
@hionay
Copy link
Contributor Author

hionay commented Dec 2, 2022

@noxer thanks for the review. I pushed the changes.

Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much @hionay. I'll added Ibrahim as a second reviewer and then this PR is ready to merge.

Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hionay 🚀

@isacikgoz isacikgoz merged commit 9de7f29 into mattermost:master Dec 7, 2022
@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 7, 2022
@hionay hionay deleted the issue/21475-error-handling-removeUserFromTeam branch December 7, 2022 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmctl: Review removeUserFromTeam function to return an error in case of a failure
4 participants