-
Notifications
You must be signed in to change notification settings - Fork 155
MM-47811: improve error handling for removeUserFromTeam function #616
MM-47811: improve error handling for removeUserFromTeam function #616
Conversation
Hello @hionay, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hionay, thank you very much for your contribution. I'd like to request a few changes. Otherwise this looks good.
@noxer thanks for the review. I pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you very much @hionay. I'll added Ibrahim as a second reviewer and then this PR is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hionay 🚀
Summary
Error handling for the
removeUserFromTeam
function updated to return an error in case of failure.Update includes the use of
multierror.Error
for appending all errors and returning error if one occurs for the functionteamUsersRemoveCmdF
.Ticket Link
Fixes mattermost/mattermost#21475