This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Showing websockets events as strings instead of as bytes arrays #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
approved these changes
Mar 2, 2023
isacikgoz
approved these changes
Mar 3, 2023
|
Good to merge after having a green CI :) cc @jespino |
isacikgoz
added
the
4: Reviews Complete
|
@isacikgoz @mgdelacroix I'm out until Wednesday so feel free to modify the pr if you are in the mood. If not, I'll do it when I come back. |
|
fixed bumping up the golangci version in the github workflow definition |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the
mmctl websocketcommand to monitor the debugbar information and was showing me byte arrays. This PR prints strings instead.