-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket error after upgrading to 1.3.0 #1812
Comments
Nothing has changed with websockets from 1.2 to 1.3. There has been some changes around it, but the underlying connection has stayed the same for several versions. The *.go files haven't been touched in months. See |
Hi @gsmet, please see if this repros if you're on a wired connection instead of Wifi? I've seen this error intermittently on mobile sometimes when I'm on a bad connection, |
Hi, We are all using a wired connection (and different ones). And it's 100% reproducible for all our users on Firefox. |
I can confirm the same issue, after some hours of uptime (haven't worked out how long yet) the websocket error appears as op stated. I am using |
For me the problem is partially reproducable. In the office environment (ipsec vpn to datacentrum, apache proxy / ssl endpoint) Firefox does have a problem. When using chrome / ie from the same location the problem does not show itself. |
Can you look at the browser console and paste any errors you see into this thread. Right Click > Inspect Element > Console |
The lines below appear in the console when clicking on another channel, at which point the blue line, with the websocket error appears
|
An additional update, when attempting to dig a little further in de console I found the following lines, which might be relevant.
|
As for me, the upgrade of the connection to websocket goes OK but then I have the following in the console: Nothing in the Mattermost log. |
@woutervb looks like the proxy isn't configured correctly. Most of the errors are referring to std http get/post calls and have nothing todo with the websocket. For example |
@gsmet I think your issue is different. The error message you shared is coming from firefox and not mattermost. I'm thinking it might be this issue https://bugzilla.mozilla.org/show_bug.cgi?id=712329. What version of firefox are you using? what OS? any non-std stuff installed like adblocker? |
@woutervb you're hitting https://github.com/mattermost/platform/blob/master/web/react/utils/async_client.jsx#L55 which is trying to call |
@coreyhulen I'm not sure what you exacly mean. The headers I can check at a later moment that remark is clear. My setup is a proxy that only handles https, and does not even respond to http requests, using the apache recipie found at https://mattermost.atlassian.net/browse/PLT-635, only using a different ip adres for the mattermost installation. When clicking a channel the url bar of the browser changes to the new channel name, but I am not sure that, that is what you are referring to. |
@coreyhulen I did find this Firefox bug but what bugs me is that I have the problem even if launch a brand new instance of Firefox. Moreover, it's definitely related to the Mattermost upgrade to 1.3 as we didn't have the problem before and nothing else has changed on our setup. That being said, to be on the safe side, maybe you could include the workaround described here to Mattermost: https://bugzilla.mozilla.org/show_bug.cgi?id=712329#c12 . All the users at my company have this issue. My install: Firefox 42, Ubuntu Trusty, Adblock edge but I tried to disable it and the problem is still there. |
@coreyhulen Just checked the headers, and see that X-version-Id is received on the requests (and a pragma: no-cache on the static elements, which striked me odd, but is unrelated) |
@woutervb would you mind sharing some of the network traffic as seen by firefox? Please feel free to blur/remove any sensitive data and/or direct message me at pre-release.mattermost.com |
@woutervb something like |
@gsmet yeah, we'll start on the workaround. I'm also not sure what has changed between 1.2 and 1.3 that would cause the issue. I've been looking at the history of https://github.com/mattermost/platform/blob/master/web/react/stores/socket_store.jsx and cannot see any substantive changes that would be causing the issue. Can you connect a firefox browser directly too the box bypassing the proxy as a test? I just want to rule out an any apache proxy issue. I think @woutervb problem is different. I'm still leaning towards an apache config issue with their vpn environment for him because of the comment |
@gsmet the only change I see is how we clear the error 75a2ce0. Maybe it's reconnecting and the error for the blue bar isn't getting cleared. After you see |
One of our users was getting |
The websocket error also occurs when I'm not passing through a proxy. I don't have any other message regarding websockets in the console. Here are the queries executed on a regular basis (I don't know if it states that websockets actually are working or not):
|
Sorry for the long delay. I missed that there where updates. I did change my apache proxy configuration by adding:
Which removed the symptoms of double loading on channel switch. So as far as I can see I have a fully functional setup, with apache reverse proxy, handling name based ssl. P.S. Found the above mentioned change on: http://forum.mattermost.org/t/too-many-detected-version-update-refreshing-the-page-when-proxying-with-apache/688 |
@woutervb we would love some documentation for what worked with apache. |
@coreyhulen Nice, thanks! |
@gsmet, @woutervb @adrianduke thanks to all for reporting issues and helping advance the conversation. It seems:
I'm closing this ticket and would ask the help of people on the thread to see if the mix of Mattermost 2.0 and the new configuration instructions solves the issue. If not, please open a new ticket with repro steps on your specific configuration. |
Hi !
After my upgrade to GitLab 8.3 and Mattermost 1.3.0, I have websocket errors at the top of the page:
Please check connection, Mattermost unreachable. If issue persists, ask administrator to check WebSocket port.
In the Apache server-status, all the requests to the API (GET /api/v1/websocket?session_token_index=0 HTTP/1.1) are stalled (status working).
It was working perfectly before the upgrade so I'm wondering if something was changed?
FYI, I use Apache's mod_proxy_ws_tunnel to upgrade my websocket requests but it used to work perfectly before the upgrade of Mattermost.
Any hints, ideas, advices on how to diagnose the issue?
Thanks!
The text was updated successfully, but these errors were encountered: