Fixed @ not working on latest build due to...

[prixone]

Summary

On latest build the @ shortcut to search for mentions was not working due to missing parameters on the performSearch method used by the onListenerChange method, due to changes done previously to post_action and search_bar that were not made to the performSearch that exists within the onListenerChange method.

Ticket Link

NONE

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Added or updated unit tests (required for all new features)
• Added API documentation (required for all new APIs)
• All new/modified APIs include changes to the drivers
• Has enterprise changes (please link)
• Has UI changes
• Includes text changes and localization file (.../i18n/en.json and .../webapp/i18n/en.json) updates
• Touches critical sections of the codebase (auth, upgrade, etc.)

[mattermod]

Thanks @prixone for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

[jwilander]

@lindalumitchell did you have a chance yet to test this out?

[lindalumitchell]

Ah, thank you @jwilander; I didn't see this one come through. I just tested, and the at-mention search is working as expected on the spinmint server. No issues found.

[prixone]

Sorry everyone, I've found a new issue here and since it hasn't been pushed out I've merged it.

from:

if (doSearch) {

to:

if (doSearch && newState && newState.searchTerm.length) {

Basically, if the user does not have the option Your non-case sensitive username "user" selected at the notification settings for mentions, see image below:

The system does not give anything to the search field thus this fix should avoid it from submitting the request in this specific scenario to avoid an "invalid search term" from being sent to the server.

I've looked thru the commits on that file for previous commit but NONE seemed to deal with or change this behavior so I assume that when the user does not have anything select, not sending the request to the server is the correct behavior here.

@lindalumitchell sorry to disturb you, would you mind testing for the above mentioned? thanks.

[mattermod]

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

[mattermod]

Spinmint test server created at: http://i-0406880c488984158.spinmint.com:8065/pr5878

Test Account 1: Email: test@test.com | Password: passwd

Test Account 2: Email: test2@test.com | Password: passwd

Instance ID: i-0406880c488984158

[lindalumitchell]

@prixone @jwilander @jasonblais I re-tested for the described scenario, with all boxes in the Words that trigger mentions setting unchecked. Clicking the @ icon does nothing in that case (even though @[username] still triggers a mention). No errors observed.

When at least one option is checked, the @ icon displays mentions in RHS as expected.

It sounds like the scenario with no mention options checked is a separate issue, and I'll file a separate bug for that one (https://pre-release.mattermost.com/core/pl/ycs8oijwcjfadmc8donc4kx7tr).

So this one checks out; no issues found.

[mattermod]

Spinmint test server destroyed