Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-45236] Improve auditing of joining sessions #145

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

streamer45
Copy link
Contributor

Summary

PR improves logging of which sessions join calls, including all the most important IDs.

Example:

debug [2024-06-05 14:44:32.751 +02:00] session has joined call                       caller="rtc/sfu.go:655" userID=zjm6x7y4n3gjzfj7kw3xp9c9se sessionID=5dbfn67ubtr3fkhqb9octcu5iy channelID=oi18bftr738ntn35xnyjyed9uh callID=g3y3k1to57y85puaccnwgj7ber

Ticket Link

https://mattermost.atlassian.net/browse/MM-45236

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Jun 5, 2024
@streamer45 streamer45 added this to the v0.16.0 milestone Jun 5, 2024
@streamer45 streamer45 requested a review from cpoile June 5, 2024 12:45
@streamer45 streamer45 self-assigned this Jun 5, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 5, 2024
@streamer45 streamer45 merged commit 05adcec into master Jun 5, 2024
2 checks passed
@streamer45 streamer45 deleted the MM-45236 branch June 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants