Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FPN, top-down and backbone configurable #561

Merged
merged 4 commits into from
Jun 5, 2018

Conversation

julienr
Copy link

@julienr julienr commented May 15, 2018

This adds two new config options : Config.FPN_CLASSIF_FC_LAYERS_SIZE and Config.TOP_DOWN_PYRAMID_SIZE to allow the user to specify the size of those layers.

This also adds a Config.BACKBONE option that allow one to use a custom backbone by providing a function that should return a backbone graph.

Also fix #170 and allow dashes in model name when trying to restart from an epoch.

Julien Rebetez added 4 commits May 15, 2018 12:11
Print a message when re-starting from saved epoch
This allows one to set a callable in Config.BACKBONE to use a custom
backbone model.
@benqua
Copy link

benqua commented May 17, 2018

+1 would love to see this PR merged. It fixes two issues I am facing right now!

(BTW, wouldn't it be better (easier to get merged) to have 4 distinct PR?)

@julienr
Copy link
Author

julienr commented May 17, 2018

I can definitely split this into 4 if it makes things easier; whatever the maintainer prefers

@waleedka waleedka merged commit 398b86d into matterport:master Jun 5, 2018
@waleedka
Copy link
Collaborator

waleedka commented Jun 5, 2018

Interesting additions. The three commits that add the backbone configuration and allow dashes in model names look good and elegantly done.

The fix for #170 is, I think, a step in the right direction but doesn't completely solve the problem. It solves the case when there are no ground truth boxes, but the code still fails at a later stage. In my test, on TF 1.8, I get a core dump. But, one step at a time, so I'll merge this and address the other issue separately.

Thank you, great PR.

@julienr
Copy link
Author

julienr commented Jun 8, 2018

Thanks for merging !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error raise when positive_overlaps has shape (0,0), how to fix?
3 participants