Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

Remove dependency on all drivers #60

Closed
jbuchbinder opened this issue Nov 2, 2015 · 3 comments
Closed

Remove dependency on all drivers #60

jbuchbinder opened this issue Nov 2, 2015 · 3 comments

Comments

@jbuchbinder
Copy link

The current setup loads all drivers, rather than having them loaded by the end user. This means that any dependency which requires CGO to build -- and is therefore not able to be cross-compiled. This seems to be the case for at least the PostgreSQL and Sqlite3 drivers.

I'm seeing this paradigm in the driver code : https://github.com/mattes/migrate/blob/master/driver/driver.go

Instead of calling a single driver.New() method, it might make more sense to have a New() method implemented by each driver?

@AlekSi
Copy link

AlekSi commented Nov 6, 2015

+1. Also it would be nice to have build tags for specific drivers.

@danilobuerger
Copy link

👍

@mattes
Copy link
Owner

mattes commented Nov 11, 2015

Please see #54

@mattes mattes closed this as completed Nov 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants