Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poisson Solver does not actually run to convergence #5

Closed
MattFerraro opened this issue Aug 18, 2021 · 1 comment
Closed

Poisson Solver does not actually run to convergence #5

MattFerraro opened this issue Aug 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MattFerraro
Copy link
Owner

Repeatably only the first iteration of the Poisson Solver will actually run to convergence of epsilon < 1e-5. Subsequent runs never converge and instead time out with epsilon ~ 0.05.

This probably isn't a huge problem but it indicates a weakness in the solver or a weakness in the conditioning. Perhaps the integral of the loss is no longer equal to zero and just needs to be re-centered?

@MattFerraro MattFerraro added the bug Something isn't working label Aug 18, 2021
@MattFerraro
Copy link
Owner Author

Yep, the fix was simply to shift the loss function up or down such that sum(loss) = 0 before handing it to the poisson solver. Same for the heightmap solver. It now reliably and quickly converges.

@MattFerraro MattFerraro self-assigned this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant