Strict folding for folding.el + failsafe for other modes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattfidler
added a commit
that referenced
this pull request
Nov 13, 2013
Strict folding for folding.el + failsafe for other modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
(Follow-up from #1 (sorry if there is a better way of doing this, not familiar enough with guthub yet).)
The function should-fold-p was still not called out of hs-minor-mode. I also improved the test for folding.el, it turns out there was a ready-to-use function for our test.
I also added the failsafe code I was suggesting for TeX-fold, outline-minor-mode and nxml, so that "strict" doesn't mean "disabled" for these modes.