Progress View #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work, as usual 👍 I refactored the timing to use Signal.interval since I would rather use a reactive approach. However, this does raise the point that I should probably provide a Signal.caDisplayLink or similar function. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be interesting to investigate providing a single interface for providing progress.
UIProgressViewhas two,observedProgress: Progress?andprogress: Float.For now I have provided the straight forward bindings for both interfaces. But if someone likes the idea of providing one interface, probably a nicer wrapper of
Progressfor theobservedProgressproperty onUIProgressView, I would be happy to investigate doing so.