Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASM output for the zig compiler #1711

Merged
merged 1 commit into from Nov 28, 2019

Conversation

haze
Copy link
Contributor

@haze haze commented Nov 28, 2019

This fixes #1689 by using the suggestion @andrewrk made.

This also properly disables the demangler for compilers that don't provide one.
(There was a bug where path.normalize would turn an empty string into ..)

@haze haze changed the title Fix ASM output on for the zig compiler Fix ASM output for the zig compiler Nov 28, 2019
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #1711 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1711      +/-   ##
=========================================
+ Coverage   56.29%   56.3%   +<.01%     
=========================================
  Files          64      64              
  Lines        5020    5021       +1     
=========================================
+ Hits         2826    2827       +1     
  Misses       2194    2194
Impacted Files Coverage Δ
lib/compiler-finder.js 40% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f055b1...eb3df6f. Read the comment docs.

@RubenRBS
Copy link
Member

Thanks for taking the time to fix the Zig compilers :)
Also, great catch with the demangler fix. I'll merge now and it should hit the live site in the next few days

@RubenRBS RubenRBS merged commit e77f0dd into compiler-explorer:master Nov 28, 2019
@haze haze deleted the fix/zig-emit-asm branch July 20, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Zig >0.3.0 does not have ASM output
2 participants