New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake added #14
CMake added #14
Conversation
… no v3.x availalbe on travis yet.
Thanks for this great contribution. I will take a proper look over the next
|
Great! 👍 With cmake i was able to cross-compile for an embedded Arm - seasocks works like a charm! |
This is great stuff; thanks! I'll merge in and once we get a decent way of pointing at gmock I'll probably deprecate the old configure-based stuff in favour of CMake. |
CMake added. Currently alongside the autoconf build; with a view to it replacing autoconf sometime soon.
I've updated the main build to work with Catch.hpp instead of Thanks! On Sun, Oct 18, 2015 at 7:21 AM, offa notifications@github.com wrote:
Matt |
Everything fine so far. |
Just one thing: It's a bit hard to figure out, where a build failure comes from currently. |
I have addressed this in #15. |
Thanks! Merged :) |
@mattgodbolt Can we add an option for Tests, so they can (optionally) be turned off? |
Certainly! Feel free to send a PR, else I'll try and get to it later this On Wed, Oct 21, 2015 at 1:05 PM offa notifications@github.com wrote:
|
Done: #20 |
This PR addes cmake as a second build tool.
Available:
make install
emplace()
OFF
)Config.h
(based on a custom template incmake/
)Not (yet) available:
Since google has merged gtest / gmock into one project - gmock depends on gtest though - i'm not sure how to handle this case on CI. It seems gmock requires gtest but doesn't ship it anymore in one bundle (?).
At the moment cmake will look for both if tests are enabled, otherwise there's no dependency on gtest / gmock if disabled.
What's different to autoconf:
The cmake builds will use it's own
Config.h
(cmake
directory); it has only a definition forHAVE_UNORDERED_MAP_EMPLACE
, since i didn't see any usage of all the other flags. However, adding more options is simple enough.