feat: Error handling #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgoucher
reviewed
Aug 31, 2017
src/index.js
Outdated
| */ | ||
| command(cmd) { | ||
| if (!this.commands[cmd]) { | ||
| throw new Error(`Specified command: ${cmd} is invalid`); | ||
| } |
mattgoucher
reviewed
Aug 31, 2017
src/index.js
Outdated
| @@ -147,6 +154,10 @@ export default class Luxafor { | |||
| * @return {object} Instance | |||
| */ | |||
| color(r = 0, g = 0, b = 0) { | |||
| if (invalidNums([...arguments])) { | |||
| throw new Error(`Specified values: ${[...arguments]} are invalid`); | |||
| } | |||
There was a problem hiding this comment.
I think we should move this to exec() method, so it's not duplicated for each additional method.
mattgoucher
reviewed
Aug 31, 2017
src/index.js
Outdated
| }); | ||
|
|
||
| return invalid; | ||
| } |
There was a problem hiding this comment.
Because we're not using the returned value, it might make sense to send back a bool
function hasInvalidArguments(nums) {
return nums.some(num =>
!Number.isInteger(num) || num < 0 || num > 255;
);
}
mattgoucher
reviewed
Aug 31, 2017
| ], | ||
| ] | ||
| `; | ||
| exports[`Luxafor exec Should execute the write for only one led position 1`] = `Array []`; |
There was a problem hiding this comment.
I don't think this is expected for this test. Should it have written to the entire lux instead?
it('Should execute the write for only one led position', () => {
const instance = setup()
.color(0, 255, 0)
.exec();
expect(
instance.device.data
).toMatchSnapshot();
});
JoshKloster
commented
Sep 1, 2017
| @@ -79,6 +90,38 @@ export default class Luxafor { | |||
| return timingBytes[command]; | |||
| } | |||
|
|
|||
| validate() { | |||
There was a problem hiding this comment.
Not sure how much I like how this is done.
JoshKloster
commented
Sep 1, 2017
| @@ -92,6 +135,8 @@ export default class Luxafor { | |||
| * TODO: Should pattern clear out command byte? | |||
| */ | |||
| write({command = 'color', position = 'both', r = 0, g = 0, b = 0, pattern, speed, repeat}) { | |||
| this.validate(); | |||
There was a problem hiding this comment.
Again, not sure how much I like this here.
JoshKloster
commented
Sep 1, 2017
| @@ -109,30 +154,24 @@ export default class Luxafor { | |||
| * @returns {object} Instance | |||
| */ | |||
| exec() { | |||
|
|
|||
There was a problem hiding this comment.
This was a bug, not being able to do commands without specifying any ledPositions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic error handling. Also change ledPositions to always be an array.