Allows self signed certs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code-wise, this looks great. Unfortunately I don't have an active RM subscription at the moment, so I'm unable to test. I see the automated test suite passed fine, so that's good! But I may just put this in master for the time being until someone else comes along and tries it. I'm not sure what to do long-term, really, so I'm curious what your thoughts are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsequently found out that you can enable self signed certs by dragging the certificate file onto the emulator, which allows you to install it on that device. I still feel this PR is still valid for development purposes where you aren't able to do this.