forked from cloud-custodian/cloud-custodian
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query parser consolidation draft #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like this is targeting the wrong repo/branch re its targeting your fork vs the upstream repo. |
Oh yeah that was intentional. Been using this fork as a staging area for working draft PRs until they're fully ready to go. I'll target the upstream repo once I've finalized it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cloud-custodian#9469, cloud-custodian#9408
Filters
key are still supported via the implicit_qfilter_translate function in the QueryParser class. This will raise a PolicyValidation error if query parameters and query filters are mixed without listing the query filters properly under the 'Filters' keybotocore.exceptions.ParamValidationError: Parameter validation failed: Unknown parameter in input: "Filters", must be one of: NextToken, MaxResults, state
, so the current version of directory queries as a list of "Name", "Values" dictionaries will no longer be supported in favor of key value pairs to mirror the list_directories API structure.New Functionality:
EC2:
EBS Snapshots:
Sagemaker Jobs:
IAM Policies:
All
orAWS
EMR:
Directory:
There are a number of other resource types whose queries could be easily implemented or simplified in the future such as ops-item, ssm-document, codedeploy-deployment, dms-instance, etc.