Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to sanitize rpaths #164

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Oct 24, 2022

Fixes #101

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (082ab1e) 95.11% compared to head (ccc82a1) 95.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   95.11%   95.21%   +0.10%     
==========================================
  Files          15       15              
  Lines        1167     1192      +25     
==========================================
+ Hits         1110     1135      +25     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhilipGarnero
Copy link
Contributor

Can we merge this ? Work seems good to me. Even if deemed not perfect, it's more useful than nothing.
A click on the merge button please ! 🙇‍♂️

@HexDecimal
Copy link
Collaborator

The fakepkg_rpath wheel adds lib/ to its rpaths to more easily link its libraries with delocate, but it's not what you'd want in a post-delocated wheel so I've added a test which sanitizes it away.

I've edited this PR so that only @executable_path/ and @loader_path/ are allowed when sanitizing. Which I think is what's expected but it's hard to tell.

isuruf and others added 3 commits November 21, 2023 18:54
@HexDecimal HexDecimal merged commit 979c7ef into matthew-brett:master Nov 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sanitize rpaths
4 participants