ENH: allow threshold for mat2axangle precision #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to set precision for mat2axangle check for rotation matrix precision. Make default threshold more liberal.
|
@ikrase - any comment here? |
|
Ooh, I'm sorry, I wasn't aware that it was my comment you were asking for. On Mon, Sep 7, 2015, 5:08 PM Matthew Brett notifications@github.com wrote:
|
|
This looks good. |
|
Great - thanks. |
matthew-brett
added a commit
that referenced
this pull request
Sep 8, 2015
MRG: allow threshold for mat2axangle precision Allow user to set precision for mat2axangle check for rotation matrix precision. Make default threshold more liberal. Closes gh-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to set precision for mat2axangle check for rotation matrix
precision.
Make default threshold more liberal.
Closes gh-3