Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babashka test/*report-counters* is a ref instead of an atom for bb >= 1.1.171 #18

Closed
borkdude opened this issue Feb 9, 2023 · 2 comments

Comments

@borkdude
Copy link

borkdude commented Feb 9, 2023

The tests are failing with bb >= 1.1.171 due to binding test/*report-counters* to an atom instead of a ref. bb 1.1.171 fixes this incompatibility with Clojure. I think a lot of .cljc files could become .clj files due to this change.

@matthewdowney
Copy link
Owner

Ah just saw this also, got it!

Perhaps the way to go is a macro which checks the Babashka version (if on bb) and emits atom / ref accordingly, to maintain backwards compatibility for anyone running older Babashka versions.

I'll give this a shot later today.

@borkdude
Copy link
Author

borkdude commented Feb 9, 2023

I'd say just drop support for the older babashka versions to keep it simple, this will also encourage people to upgrade. There's usually not a reason not to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants