Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shape plots #19

Merged
merged 2 commits into from Nov 16, 2020
Merged

feat: Add shape plots #19

merged 2 commits into from Nov 16, 2020

Conversation

matthewfeickert
Copy link
Owner

@matthewfeickert matthewfeickert commented Nov 16, 2020

* Add plot.shape_hist API
* Make density a kwarg for plot API
* Add plot.shape_hist to examples notebook

@matthewfeickert matthewfeickert added the enhancement New feature or request label Nov 16, 2020
@matthewfeickert matthewfeickert self-assigned this Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #19 (6ae3dec) into master (f8b3006) will decrease coverage by 6.84%.
The diff coverage is 3.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   35.71%   28.87%   -6.85%     
==========================================
  Files           6        6              
  Lines         112      142      +30     
  Branches       17       27      +10     
==========================================
+ Hits           40       41       +1     
- Misses         72      101      +29     
Flag Coverage Δ
unittests 28.87% <3.33%> (-6.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/heputils/plot.py 15.31% <3.33%> (-4.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b3006...6ae3dec. Read the comment docs.

@matthewfeickert matthewfeickert merged commit cea19d8 into master Nov 16, 2020
@matthewfeickert matthewfeickert deleted the feat/add-shape-plots branch November 16, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant