Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add histstyle kwarg to plot.shape_hist #26

Merged
merged 2 commits into from Nov 22, 2020

Conversation

matthewfeickert
Copy link
Owner

Resolves #25

Add histstyle kwarg to enable setting step as the histstyle for mplhep. Still default to fill as default style.

* Add histstyle kwarg to allow for 'step' style (lines)
* Add example of using 'step' style to example notebook

@matthewfeickert matthewfeickert self-assigned this Nov 22, 2020
@matthewfeickert matthewfeickert added the enhancement New feature or request label Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #26 (543b79b) into master (8822879) will decrease coverage by 0.79%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   29.37%   28.57%   -0.80%     
==========================================
  Files           7        7              
  Lines         143      147       +4     
  Branches       27       28       +1     
==========================================
  Hits           42       42              
- Misses        101      105       +4     
Flag Coverage Δ
unittests 28.57% <0.00%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/heputils/plot.py 14.78% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8822879...543b79b. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 2c2facd into master Nov 22, 2020
@matthewfeickert matthewfeickert deleted the feat/add-step-style branch November 22, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for line shape histogram plots
1 participant