Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure uncertainty bars don't extend below 0 #47

Merged
merged 6 commits into from Mar 12, 2021

Conversation

matthewfeickert
Copy link
Owner

@matthewfeickert matthewfeickert commented Mar 12, 2021

Resolves #41

* Ensure the bottom of uncertainty bars don't extend below 0
   - Avoid axis limits dropping below 0
* Rebin example histograms
   - Avoid running into range limitations of ATLAS Style
* Set lower bound on hist to v2.2.0
   - Pickup boost-histogram v1.0 and mplhep v0.2.16+
* Add VS Code settings to gitignore

Huge thanks goes out to @henryiii and @andrzejnovak for their impressive work on hist and mplhep!

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #47 (79185bc) into master (5daa77a) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   28.09%   27.83%   -0.27%     
==========================================
  Files           7        7              
  Lines         210      212       +2     
  Branches       39       39              
==========================================
  Hits           59       59              
- Misses        151      153       +2     
Flag Coverage Δ
unittests 27.83% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/heputils/plot.py 18.88% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5daa77a...79185bc. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 03a1a80 into master Mar 12, 2021
@matthewfeickert matthewfeickert deleted the fix/apply-new-sizing-restrictions branch March 12, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct styling to adapt to mplhep v0.2.10+ style
1 participant