Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply scale factors to the ratio plot in stack_ratio_plot #78

Merged
merged 2 commits into from Aug 5, 2021

Conversation

matthewfeickert
Copy link
Owner

Resolves #76

* If `stack_ratio_plot` is given a `scale_factors` kwarg apply the scale factors to both the main plot as well as to the ratio plot
* In the dev-notebook reduce the rp_ylim for the stack_ratio_plot example to focus more

@matthewfeickert matthewfeickert self-assigned this Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #78 (c9c1e68) into main (4de0427) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   64.75%   64.48%   -0.27%     
==========================================
  Files           7        7              
  Lines         244      245       +1     
  Branches       41       42       +1     
==========================================
  Hits          158      158              
- Misses         63       64       +1     
  Partials       23       23              
Flag Coverage Δ
unittests 64.48% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/heputils/plot.py 62.14% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de0427...c9c1e68. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 5461254 into main Aug 5, 2021
@matthewfeickert matthewfeickert deleted the fix/scaling-on-ratios branch August 5, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ratio plots seem not to account for scale factors
1 participant