Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump github.com/ory/fosite from 0.32.2 to 0.34.1 #60

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 16, 2022

Bumps github.com/ory/fosite from 0.32.2 to 0.34.1.

Changelog

Sourced from github.com/ory/fosite's changelog.

0.34.1 (2020-10-02)

fix: make redirect URL checking more strict

The OAuth 2.0 Client's Redirect URL and the Redirect URL used in the OAuth 2.0 flow do not check if the query string is equal:

  1. Registering a client with allowed redirect URL https://example.com/callback
  2. Performing OAuth2 flow and requesting redirect URL https://example.com/callback?bar=foo
  3. Instead of an error, the browser is redirected to https://example.com/callback?bar=foo with a potentially successful OAuth2 response.

Additionally, matching Redirect URLs used strings.ToLower normalization:

  1. Registering a client with allowed redirect URL https://example.com/callback
  2. Performing OAuth2 flow and requesting redirect URL https://example.com/CALLBACK
  3. Instead of an error, the browser is redirected to https://example.com/CALLBACK with a potentially successful OAuth2 response.

This patch addresses all of these issues and adds regression tests to keep the implementation secure in future releases.

Bug Fixes

  • Make redirect URL checking more strict (cdee51e):

    The OAuth 2.0 Client's Redirect URL and the Redirect URL used in the OAuth 2.0 flow do not check if the query string is equal:

    1. Registering a client with allowed redirect URL https://example.com/callback
    2. Performing OAuth2 flow and requesting redirect URL https://example.com/callback?bar=foo
    3. Instead of an error, the browser is redirected to https://example.com/callback?bar=foo with a potentially successful OAuth2 response.

    Additionally, matching Redirect URLs used strings.ToLower normalization:

    1. Registering a client with allowed redirect URL https://example.com/callback
    2. Performing OAuth2 flow and requesting redirect URL https://example.com/CALLBACK
    3. Instead of an error, the browser is redirected to https://example.com/CALLBACK with a potentially successful OAuth2 response.

    This patch addresses all of these issues and adds regression tests to keep the implementation secure in future releases.

Documentation

0.34.0 (2020-09-24)

chore: fix unused const linter error (#484)

Breaking Changes

fosite.ErrRevocationClientMismatch was removed because it is not part of RFC 6749. Instead, fosite.ErrUnauthorizedClient will be returned when calling RevokeToken with an OAuth2 Client which does not match the Access or Refresh Token to be revoked.

Bug Fixes

... (truncated)

Commits
  • cdee51e fix: make redirect URL checking more strict
  • eb87048 chore: update repository templates
  • 2f3a7de ci: add HISTORY.md to .reference-ignore
  • ec850f3 chore: update repository templates
  • 19232ab autogen(docs): regenerate and update changelog
  • 5c8b91c chore: update repository templates (#500)
  • 2889039 autogen(docs): regenerate and update changelog
  • 6626604 chore: update repository templates (#492)
  • 2a9002e autogen(docs): regenerate and update changelog
  • a822244 docs: added missing dot (#487)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 16, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 371

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 27.121%

Totals Coverage Status
Change from base Build 369: 0.0%
Covered Lines: 780
Relevant Lines: 2876

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 16, 2022

Pull Request Test Coverage Report for Build 371

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 27.121%

Totals Coverage Status
Change from base Build 369: 0.0%
Covered Lines: 780
Relevant Lines: 2876

💛 - Coveralls

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale 👃 Issues that have gone smelly due to a number of days of inactivity.. label Jul 31, 2022
@matthewhartstonge matthewhartstonge removed the issue/stale 👃 Issues that have gone smelly due to a number of days of inactivity.. label Jul 31, 2022
Bumps [github.com/ory/fosite](https://github.com/ory/fosite) from 0.32.2 to 0.34.1.
- [Release notes](https://github.com/ory/fosite/releases)
- [Changelog](https://github.com/ory/fosite/blob/master/CHANGELOG.md)
- [Commits](ory/fosite@v0.32.2...v0.34.1)

---
updated-dependencies:
- dependency-name: github.com/ory/fosite
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/ory/fosite-0.34.1 branch from 1de8fea to 10a83f9 Compare August 8, 2022 03:12
@matthewhartstonge
Copy link
Owner

matthewhartstonge commented Sep 27, 2022

As an FYI:

This hasn't been merged in as there is a breaking change to the JWTs that arrived in ~v0.34.X that's a big change, while not related to storage, the dependence on the fosite version can impact users, which is why I haven't been able to bump this yet.

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale 👃 Issues that have gone smelly due to a number of days of inactivity.. label Dec 16, 2022
@stale stale bot closed this Dec 26, 2022
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Dec 26, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/ory/fosite-0.34.1 branch December 26, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file issue/stale 👃 Issues that have gone smelly due to a number of days of inactivity.. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants