Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: changeOrientationList[index] is not a function #233

Open
hymair opened this issue Jan 6, 2020 · 3 comments
Open

Uncaught TypeError: changeOrientationList[index] is not a function #233

hymair opened this issue Jan 6, 2020 · 3 comments
Labels
bug-major Bugs that are affecting production users.

Comments

@hymair
Copy link

hymair commented Jan 6, 2020

This error is logged on resize.

image
image

@matthewhudson
Copy link
Owner

Thanks for reporting @hymair.

I can't replicate it on my end. Can you share User Agent / more details where you discovered this?

@hymair
Copy link
Author

hymair commented Jan 9, 2020

Happens on latest Chrome. Here's some debugging:

image
image

So looks like it's trying to execute landscape('landscape') as a function, but there's no such function. Let me know if you need any more specific info.

@robertogrip
Copy link

Would it be possible to validate if it is a function before?

typeof changeOrientationList[index] === 'function' && changeOrientationList[index](newOrientation);

@matthewhudson matthewhudson pinned this issue Jan 15, 2021
@matthewhudson matthewhudson added the bug-major Bugs that are affecting production users. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-major Bugs that are affecting production users.
Projects
None yet
Development

No branches or pull requests

3 participants