Combine common code b/w Monster and User #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using **kwargs, we can easily pass all the parameters to the User constructor in a dictionary without requiring the constructor to contain parameters for the values that both it _and_ Entity need. Whatever User needs will not be in the **kwargs passed to Entity, so Entity only gets the leftovers. * This model should help with instances of Pylint too-many-arguments going forward. As part of these changes, I've also made it so that User is instantiated directly using the DB document, as well as the Monster being instantiated directly using the values from the YAML. This requires that User/Monster/Entity member names match DB/YAML field names, though transform functions could easily be created later on to switch between what the YAML/DB needs and what the code needs. For the time being, the simplicity is nice as I'm adding new fields, etc., though the negatives are clear with an approach like this. It should not be something that stays indefinitely.
This was referenced Aug 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
**kwargs, we can easily pass all the parameters to theUserconstructor in a dictionary without requiring the constructor to
contain parameters for the values that both it and
Entityneed.Whatever User needs will not be in the
**kwargspassed to Entity,so Entity only gets the leftovers.
going forward.
As part of these changes, I've also made it so that
Userisinstantiated directly using the DB document, as well as the
Monsterbeing instantiated directly using the values from the YAML. This
requires that
User/Monster/Entitymember names match DB/YAML field names,though transform functions could easily be created later on to switch
between what the YAML/DB needs and what the code needs. For the time
being, the simplicity is nice as I'm adding new fields, etc., though
the negatives are clear with an approach like this. It should not be
something that stays indefinitely.