support circle's etc.. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this implemented. Maybe you want to take a look at it again @matthewmueller? |
|
sweet, looks pretty good to me |
|
haha oh yah, i forgot to review this. looks great, thanks man! On Sun, Mar 9, 2014 at 6:15 PM, TJ Holowaychuk notifications@github.comwrote:
|
|
You may also want to merge my master branch. It supports paths, polylines and use elements. Not sure why I didn't push those commits to this PR branch. I guess I thought it was already a big enough PR :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored a bit to support the different element types without a lot of internal conditionals and switched from a
draw('rect')api to adraw.rect().