Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the reporter module is not loaded multiple times. #205

Conversation

ArturT
Copy link
Contributor

@ArturT ArturT commented Mar 31, 2017

Ensure the reporter module is not loaded multiple times when before(:suite) is run multiple times because of calling RSpec::Core::Runner more than once.

Related issue: buildkite/docs#99

This PR fix problem with capybara-screenshot not working with gem knapsack_pro

before(:suite) is run multiple times because of using RSpec::Core::Runner

Related issue: buildkite/docs#99
@toolmantim
Copy link

This fixes it for me!

ArturT added a commit to KnapsackPro/rails-app-with-knapsack_pro that referenced this pull request Mar 31, 2017
@ArturT
Copy link
Contributor Author

ArturT commented Mar 31, 2017

I noticed the tests failed for ruby 2.0.0 on travis. But it's a separate issue: #206

@mattheworiordan
Copy link
Owner

Excellent, thanks for this contribution.

@mattheworiordan mattheworiordan merged commit 5183d3d into mattheworiordan:master Apr 3, 2017
@ArturT
Copy link
Contributor Author

ArturT commented Apr 4, 2017

@mattheworiordan Thanks for merging. Are you going to release a new gem version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants