Add previous/next message arrows in ThreadDetailViewController #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed but breaks build on Xcode 7.3)
|
Not sure what's going on with the Travis build... theoretically my changes have no impact on that. Would you mind trying to build the branch on your machine? |
|
This looks great, thanks! I'll get this integrated in the next release (hopefully sooner rather than later depending on how busy the next week is). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Charter quite often these days to stay informed about Swift's evolution (thanks for making the app, by the way!)
One thing I find tedious is navigating within a thread. I often want to get a feel for the general opinion on a specific subject instead of reading everyone's whole argument in detail.
This pull request adds previous/next arrows to the ThreadDetailViewController navigation bar to jump instantly between replies instead of having to scroll manually through long messages and threads.