Fix library for proper Compiler-Level Optimization Setting (Release Build Crash Fix)

[ghost]

I recently submitted my app to the store not realizing this library requires the optimization level of the compiler to be set to 'None' or it crashes on launch for release build. As a result, it was rejected by Apple due to crashing on start up.
I have since changed it to 'None' and now the app runs fine on release build, but reading Apple's documentation it states specifically the following for Compiler-Level Optimization of type None:

 None - The compiler does not attempt to optimize code. Use this option during development when you are focused on solving logic errors and need a fast compile time. Do not use this option for shipping your executable.

The Do not use this option for shipping your executable concerns me a bit for releasing a non-optimized build to the App Store.
Is there any possibility of fixing this library to not require this setting?

[ghost]

From my brief research, I think the issue may be stemming from your use of these in the library:

 Unmanaged<AnyObject>? 
 UnsafeMutablePointer<Unmanaged<AnyObject>?>

Here are some related issues I found that discussed the same problem:
http://stackoverflow.com/questions/9431583/crash-at-any-optimization-level-other-than-o0-in-ios
http://stackoverflow.com/questions/24215757/using-unmanagedanyobject-as-key-in-nsmutabledictionary

[matthewpalmer]

Oh man I’m really sorry that this caused your app to be rejected :(. It's the worst when 3rd party libraries cause problems in your app.

The problem is that the Keychain Services API requires the use of an UnsafeMutablePointer to an Unmanaged AnyObject, i.e.

func SecItemCopyMatching(query: CFDictionary!, result: UnsafeMutablePointer<Unmanaged<AnyObject>?>) -> OSStatus

Unfortunately, I can't think of any way of getting around this requirement.

If possible, I recommend using @soffes's SSKeychain. It's really stable and written in Objective-C, so it shouldn't have any of these crazy issues. Hopefully Apple fixes this bug ASAP.

Sorry again,
Matt.

[beltex]

Hi @NitWitStudios & @matthewpalmer,

I can't seem to reproduce the crash. Do you have a stack trace you could share?

Pinpointing these crashes and collecting them is what the swift-compiler-crashes project does, so finding and documenting everyone of these helps.

[matthewpalmer]

I think Issue #6 Is the original incarnation of this crash. That thread has a lot more information and ways to force the crash.
If you're still unable to reproduce the crash, let me know and I'll look into it.

Cheers,
Matt.

[beltex]

Darn, I should have search for it, my mistake! Thanks Matt! :)

[moshegutman]

I was able to fix a similar issue with help from this link:
http://stackoverflow.com/questions/24145838/querying-ios-keychain-using-swift

var returnedData: AnyObject?
var results = withUnsafeMutablePointer(&returnedData) { SecItemCopyMatching(query, UnsafeMutablePointer($0)) }

[Arcrammer]

Would the compiler crash if you use withUnsafeMutablePointer()?

[moshegutman]

My project is compiling without issues. It is a valid Swift function:
http://swiftdoc.org/func/withUnsafeMutablePointer/

[olvidalo]

I replaced all the unmanaged objects with the withUnsafeMutablePointer function which seemed to have resolved at least my issue where I would get a duplicate item-error when trying to save data in the release configuration with something other than -Onone.

[matthewpalmer]

Thanks for all of the help everyone, and cheers to @olvidalo for the fix :)

[ghost]

Awesome! Thumbs up to everyone who got involved in this issue! 👍