Added missing update functionality #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #103, there is a proper way to update values in keychain -
SecItemUpdate
function.This pull request adds a new method
updateInSecureStore
. Instead of deleting and adding after,Locksmith.updateData
now uses the newupdateInSecureStore
method. Delete&Add is error prone, IMHO, I've seen the cases, when deletion returnederrSecSuccess
, but the value still persisted in keychain. Which is why I, usually, set the value to empty and then delete it.I didn't included the tests from #103, but if you would like to merge it too, the
User
class should be changed to something like this in order to pass the test:Not sure if catching
.Duplicate
is a good way, maybe one should implementfind
method to ensure no value exists before trying to callcreateInSecureStore